Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix getCellElement method not working with pinned columns #7844

Merged
merged 1 commit into from
Feb 7, 2023
Merged

[DataGrid] Fix getCellElement method not working with pinned columns #7844

merged 1 commit into from
Feb 7, 2023

Conversation

cherniavskii
Copy link
Member

Cherry-pick of #7354

@yaredtsy @cherniavskii
[DataGrid] improve querySelectors for selecting cell element (mui#7354)
fb5d5ba 
Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
Fixes mui#7093
Fixes mui#7819
@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! v5.x plan: Premium Impact at least one Premium user cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch labels Feb 6, 2023
@mui-bot
Copy link

mui-bot commented Feb 6, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 494.9 813.4 762.2 681 126.172
Sort 100k rows ms 635.4 1,276.9 799.9 897.6 211.084
Select 100k rows ms 194.6 248.1 218.3 218.92 17.128
Deselect 100k rows ms 162 288.1 201.1 220.62 50.483

Generated by 🚫 dangerJS against fb5d5ba

@cherniavskii cherniavskii marked this pull request as ready for review February 7, 2023 16:43
@cherniavskii cherniavskii merged commit 100f1eb into mui:master Feb 7, 2023
@cherniavskii cherniavskii deleted the 7093_bug_fix-master branch February 7, 2023 16:44
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request Jul 17, 2024
Open
@dexamundsen dexamundsen mentioned this pull request Aug 31, 2024
Closed
@dexamundsen dexamundsen mentioned this pull request Sep 20, 2024
Closed
@dexamundsen dexamundsen mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch component: data grid This is the name of the generic UI component, not the React module! plan: Premium Impact at least one Premium user v5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cherniavskii @mui-bot @yaredtsy